Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] Add priorityClassName config #436

Merged
merged 6 commits into from
Jan 20, 2020
Merged

[metricbeat] Add priorityClassName config #436

merged 6 commits into from
Jan 20, 2020
+33 −1

Conversation

gadiener
Copy link
Contributor

@gadiener gadiener commented Jan 9, 2020 •
edited
Loading

This PR add a priorityClassName config to metricbeat helm chart.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
cf5f14c, 3bc1e4a, 499e887

Please, read and sign the above mentioned agreement if you want to contribute to this project

@elasticcla
Copy link

Hi @gadiener, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@pbecotte
Copy link
Contributor

nice!

jmlrt
jmlrt suggested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
If we add priorityClassName for Metricbeat daemonset, we should also add it for Metricbeat deployment.

@jmlrt jmlrt added the enhancement New feature or request label Jan 20, 2020
@jmlrt
Copy link
Member

jmlrt commented Jan 20, 2020

jenkins test this please

@gadiener gadiener requested a review from jmlrt January 20, 2020 12:01
@jmlrt
Copy link
Member

jmlrt commented Jan 20, 2020

jenkins test this please

1 similar comment
@jmlrt
Copy link
Member

jmlrt commented Jan 20, 2020

jenkins test this please

@gadiener
Copy link
Contributor Author

Hi @jmlrt, I added priorityClassName to the Metricbeat deployment. I've also updated the unit test.

jmlrt
jmlrt approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit d22b337 into elastic:master Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmlrt jmlrt jmlrt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gadiener @elasticmachine @elasticcla @pbecotte @jmlrt